Enhancement: Warn on R-II path in OneDrive/non-ascii on startup #518
+35
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #502
On boot, this appears if OneDrive or non-ascii chars are detected in the path Reloaded-II is contained in:
Clicking OK dismisses and the program continues as usual.
This will appear every time if detected.
I debated about introducing "ignore permanently", but ultimately the goal of this is to inform users and reduce possible issue reports relating to path issues, so I think its wise to permanently nag the user if these scenarios are detected.
--
For the first time user, this would appear and then the R-II Tutorial would appear at the same time if the detection occurs. They must complete or skip the tutorial before they can interact with the warning. After both are dismissed the main window loads.
I don't consider this case very likely, as first time users would hopefully have been automatically moved to a safe directory per #504. And while its less than ideal visually, nothing is broken in this first-time state.